Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeimage: mark as broken on aarch64 #87760

Merged
merged 1 commit into from Jun 18, 2020

Conversation

@emilazy
Copy link
Member

emilazy commented May 13, 2020

Motivation for this change

Prevent ofborg/hydra from trying to build things that depend on freeimage until #77653 is fixed, and add a comment to consider unvendoring these dependencies since they'll probably cause a lot of issues like this in the future.

This came up while reviewing #86694.

cc @colemickens @viric

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Lassulus Lassulus merged commit 647cb38 into NixOS:master Jun 18, 2020
16 checks passed
16 checks passed
freeimage, freeimage.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
freeimage, freeimage.passthru.tests on x86_64-darwin Success
Details
freeimage, freeimage.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="089c666"; rev="089c6660b0fb3cde60cae7b2e15b6d8c2b576e4c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.