Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: 5.0.8 -> 6.0.1 #87762

Closed
wants to merge 1 commit into from
Closed

redis: 5.0.8 -> 6.0.1 #87762

wants to merge 1 commit into from

Conversation

@codyleyu
Copy link
Contributor

codyleyu commented May 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from globin May 13, 2020
@codyleyu codyleyu force-pushed the codyleyu:master branch 2 times, most recently from de3849e to 2d042ee May 14, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented May 14, 2020

Haven't reviewed this, but just FYI the CONTRIBUTING.md standard (i.e. semi-requirement) is that commits & PR titles follow the format: package: OLD_VERSION -> NEW_VERSION. You might want to rebase to fix that.

@codyleyu codyleyu force-pushed the codyleyu:master branch from 2d042ee to d65a3d9 May 15, 2020
@codyleyu codyleyu changed the title Update redis from 5.0.8 to 6.0.1 redis: 5.0.8 -> 6.0.1 May 15, 2020
@codyleyu
Copy link
Contributor Author

codyleyu commented May 15, 2020

thanks @drewrisinger, updated commit and PR title

@ajs124
Copy link
Member

ajs124 commented May 15, 2020

This is a duplicate of #87472

@ajs124 ajs124 closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.