Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.jingoo: 1.2.18 → 1.3.4 #87765

Merged
merged 1 commit into from May 14, 2020
Merged

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented May 13, 2020

Motivation for this change

Update package, switch to dune build system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also tested own project that depends on jingoo.

@sternenseemann
Copy link
Member Author

sternenseemann commented May 13, 2020

@GrahamcOfBorg build ocamlPackages.jingoo

@sternenseemann sternenseemann force-pushed the sternenseemann:ocaml-jingoo-1.3.4 branch from 4eb3e8a to d7e669c May 14, 2020
@vbgl
Copy link
Contributor

vbgl commented May 14, 2020

@GrahamcOfBorg build ocamlPackages.jingoo

@vbgl vbgl merged commit 9d55751 into NixOS:master May 14, 2020
16 checks passed
16 checks passed
ocamlPackages.jingoo on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d7e669c"; rev="d7e669c60f471a61511f96ffde9450d69d75a525"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.jingoo on x86_64-darwin Success
Details
ocamlPackages.jingoo on x86_64-linux Success
Details
@sternenseemann sternenseemann deleted the sternenseemann:ocaml-jingoo-1.3.4 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.