Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to 19.09: python: pytz: 2019.1 -> 2019.3 #87767

Closed
wants to merge 1 commit into from

Conversation

@badmutex
Copy link
Contributor

badmutex commented May 13, 2020

(cherry picked from commit 5d0b430)

Motivation for this change

Pytz 2019.01 hits the following issue (testDatabaseFixes fails) on Python 3.8
https://bugs.launchpad.net/pytz/+bug/1819751

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit 5d0b430)
@drewrisinger
Copy link
Contributor

drewrisinger commented May 15, 2020

This causes a fairly large rebuild, hence why it was originally targeted against staging. Why do you need this particular package? It's not a security fix. Can you override it just for a particular package?

@badmutex
Copy link
Contributor Author

badmutex commented May 20, 2020

oof yea :(
i'm able to override.

@badmutex badmutex closed this May 20, 2020
@badmutex badmutex deleted the badmutex:release-19.09-pytz branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.