Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/podman: libpod.conf -> containers.conf #87792

Closed
wants to merge 1 commit into from

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 14, 2020

https://github.com/containers/libpod/releases/tag/v1.9.0
Initial support for the new containers.conf configuration file has been added. containers.conf allows for much more detailed configuration of some Podman functionality

https://github.com/containers/libpod/releases/tag/v1.9.2
Packages managed by the core Podman team will no longer include a default libpod.conf, instead defaulting to containers.conf. The default libpod.conf will remain available in the Github repository until the release of Podman 2.0

https://github.com/containers/common/blob/master/docs/containers.conf.5.md

https://github.com/containers/common/blob/master/pkg/config/containers.conf

This file is also used by buildah so we might want to move it out of virtualisation.podman?

cc @NixOS/podman

@zowoq
Copy link
Contributor Author

zowoq commented May 14, 2020

@saschagrunert Are there any plans for CRI-O to use this file as well?

@adisbladis
Copy link
Member

adisbladis commented May 14, 2020

This file is also used by buildah so we might want to move it out of virtualisation.podman?

Yes, please move it over to virtualisation.containers :)

@zowoq zowoq force-pushed the zowoq:containers-conf branch from bed934e to 8993d13 May 16, 2020
@saschagrunert
Copy link
Member

saschagrunert commented May 16, 2020

@saschagrunert Are there any plans for CRI-O to use this file as well?

Not in the near term future. The idea was to migrate CRI-O on top of podman, which would give us automatically the containers.conf possibility. I can check if we can build a middle layer in the meanwhile.

@zowoq zowoq force-pushed the zowoq:containers-conf branch from 8993d13 to a790564 May 16, 2020
@zowoq
Copy link
Contributor Author

zowoq commented May 17, 2020

@ofborg test podman

@zowoq zowoq marked this pull request as ready for review May 17, 2020
@zowoq zowoq force-pushed the zowoq:containers-conf branch from 34b2360 to a790564 May 19, 2020
@zowoq zowoq mentioned this pull request Jun 20, 2020
4 of 10 tasks complete
@zowoq
Copy link
Contributor Author

zowoq commented Jun 25, 2020

Moved to #91138

@zowoq zowoq closed this Jun 25, 2020
@zowoq zowoq deleted the zowoq:containers-conf branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.