Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jrnl: 1.9.8 -> 2.4.2 #87793

Open
wants to merge 4 commits into
base: master
from
Open

jrnl: 1.9.8 -> 2.4.2 #87793

wants to merge 4 commits into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented May 14, 2020

Motivation for this change

https://github.com/jrnl-org/jrnl/releases/tag/v2.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

https://github.com/NixOS/nixpkgs/pull/87793
1 package failed to build:
python27Packages.asteval

3 packages built:
jrnl python37Packages.asteval python38Packages.asteval
@Gaelan
Copy link
Contributor

Gaelan commented May 15, 2020

Build fails on Darwin. Adding cryptography to propagatedBuildInputs fixes it.

filalex77 and others added 2 commits May 15, 2020
Co-authored-by: Jon <jonringer@users.noreply.github.com>
Fixes build on Darwin.

Co-authored-by: Gaelan <gbs@canishe.com>
@filalex77

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.