Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman, etc packages: switch to buildGoModule #87794

Merged
merged 5 commits into from May 14, 2020
Merged

podman, etc packages: switch to buildGoModule #87794

merged 5 commits into from May 14, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 14, 2020

#86376 allows us to use buildGoModule with a vendor folder.

runc currently doesn't work with buildGoModule. It will in the next release, I think we can wait for then to switch over as I don't think hacking around it is worth it, especially as runc is widely used.

cri-o already has an open PR for this change #86378

Copy link
Member

saschagrunert left a comment

LGTM, that's nice!

Copy link
Member

vdemeester left a comment

LGTM 🐯

@nlewo nlewo merged commit a33eb1a into NixOS:master May 14, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
buildah, buildah.passthru.tests, cni-plugins, cni-plugins.passthru.tests, cri-tools, cri-tools.passthru.tests, podman, podman.passthru.tests, skopeo, skopeo.passthru.tests on aarch64-linux Success
Details
buildah, buildah.passthru.tests, cni-plugins, cni-plugins.passthru.tests, cri-tools, cri-tools.passthru.tests, podman, podman.passthru.tests, skopeo, skopeo.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64ce60e"; rev="64ce60e2b36623286f0bf8bb43aec37e527228f4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:gomodules branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.