Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alot: 0.9 → 0.9.1 #87803

Merged
merged 2 commits into from May 15, 2020
Merged

alot: 0.9 → 0.9.1 #87803

merged 2 commits into from May 15, 2020

Conversation

@edibopp
Copy link
Contributor

edibopp commented May 14, 2020

Dropped the patch, as it is included in the point release.

Switched the hash representation to regular base32.

Motivation for this change

New release came out. There are a few bug fixes in it including but not limited to the patch that was already in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@edibopp edibopp requested review from FRidh and jonringer as code owners May 14, 2020
@ofborg ofborg bot added the 6.topic: python label May 14, 2020
@ofborg ofborg bot requested a review from geistesk May 14, 2020
@geistesk
Copy link
Member

geistesk commented May 14, 2020

Thanks for this change. Would you like to become the maintainer of this package? I'm no longer a user of alot and don't have the resources to maintain this package. Feel free to alter maintainers and change our names or at least drop mine.

@@ -16,18 +16,9 @@ buildPythonPackage rec {
owner = "pazz";
repo = "alot";
rev = version;
sha256 = "sha256-WUwOJcq8JE7YO8sFeZwYikCRhpufO0pL6MKu54ZYsHI=";
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";

This comment has been minimized.

Copy link
@jonringer

jonringer May 15, 2020

Contributor

most standard way in nixpkgs

Suggested change
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";
sha256 = "0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";

This comment has been minimized.

Copy link
@edibopp

edibopp May 15, 2020

Author Contributor

Oh, really? Curiously someone on IRC implied that would not be the best way to go, but no worries I'll change it.

This comment has been minimized.

Copy link
@emilazy

emilazy May 15, 2020

Member

The hash form is for SRI-style hashes (see the Nix 2.2 release notes), is the default output of new enough Nix, and will be preferred in the future, so it's fine to use.

This comment has been minimized.

Copy link
@jonringer

jonringer May 15, 2020

Contributor

oh interesting, sorry, didn't know

@edibopp
Copy link
Contributor Author

edibopp commented May 15, 2020

Thanks for this change. Would you like to become the maintainer of this package? I'm no longer a user of alot and don't have the resources to maintain this package. Feel free to alter maintainers and change our names or at least drop mine.

Yes, I use it as my daily driver at least for private mails, so I definitely want alot to keep running smoothly on NixOS. I will update the maintainers field accordingly.

Dropped the patch, as it is included in the point release.

Switched the hash representation to regular base32.
@edibopp edibopp force-pushed the edibopp:upgrade-alot-0.9.1 branch from 271f379 to 0682ec4 May 15, 2020
As requested by geistesk here:
#87803 (comment)
@edibopp
Copy link
Contributor Author

edibopp commented May 15, 2020

I changed the first commit to use the proper hash and added a second to take over as maintainer from @geistesk. So the PR should be ready to merge now.

@teto teto merged commit 7319061 into NixOS:master May 15, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
alot, alot.passthru.tests on aarch64-linux Success
Details
alot, alot.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c562954"; rev="c5629543267254aa0f6489566256d89b4aaa6078"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@edibopp edibopp deleted the edibopp:upgrade-alot-0.9.1 branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.