Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python38: 3.8.2 -> 3.8.3 #87813

Merged
merged 1 commit into from May 27, 2020
Merged

python38: 3.8.2 -> 3.8.3 #87813

merged 1 commit into from May 27, 2020

Conversation

@FRidh
Copy link
Member

FRidh commented May 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

drewrisinger left a comment

  • Diff LGTM.
  • Built & trivially tested via nixpkgs-review pr 87813 -p python38, didn't test downstream packages.
@jonringer
Copy link
Contributor

jonringer commented May 15, 2020

@GrahamcOfBorg build python38Packages.requests

Copy link
Contributor

jonringer left a comment

LGTM

@FRidh FRidh changed the base branch from master to staging May 27, 2020
@FRidh FRidh merged commit 0367fa6 into NixOS:staging May 27, 2020
18 of 21 checks passed
18 of 21 checks passed
python38, python38.passthru.tests on aarch64-linux
Details
python38, python38.passthru.tests on x86_64-darwin
Details
python38, python38.passthru.tests on x86_64-linux
Details
(unknown attributes) on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b44f66"; rev="8b44f66024b7d15a2a428c98db785ec7df9a1325"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python38Packages.requests on aarch64-linux Success
Details
python38Packages.requests on x86_64-darwin Success
Details
python38Packages.requests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.