Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #87814

Merged
merged 287 commits into from May 29, 2020
Merged

Staging next #87814

merged 287 commits into from May 29, 2020

Conversation

@FRidh
Copy link
Member

FRidh commented May 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
FRidh added 30 commits May 9, 2020
@FRidh
Copy link
Member Author

FRidh commented May 14, 2020

Do we have binutils 2.34 again on staging(-next)? Did something go wrong with merges? cc @flokli @Ericson2314 @vcunat

@flokli
Copy link
Contributor

flokli commented May 14, 2020

@FRidh staging has #85951 #86954, which is a second attempt that shouldn't break things anymore.

@jonringer jonringer mentioned this pull request May 15, 2020
3 of 10 tasks complete
@FRidh
Copy link
Member Author

FRidh commented May 17, 2020

Python's cffi fails #86954 (comment)

jtojnar and others added 5 commits May 18, 2020
https://www.nlnetlabs.nl/news/2020/May/19/unbound-1.10.1-released/
It fixes DoS CVEs; details e.g. on http://www.nxnsattack.com/

On each Linux platform this should be around 8k rebuilds,
so as a compromise I'm pushing to staging-next.
Pythons find_library is broken with binutils 2.34, and numpy could not import libraries because of not properly aligned ELF's.

This is the second time binutils 2.34 got reverted. Next time, we should have a dedicated Hydra job for it.

This reverts commit 629fa8a, reversing
changes made to 4ddd080.
Reverting this change again because we're going back to binutils 2.31.

#86954 (comment)

This reverts commit ade7fae.
@flokli
Copy link
Contributor

flokli commented May 25, 2020

It seems now python3.pkgs.cython (used by gtk-doc) fails. Might have been broken by 1ac5398 (cc @Ericson2314), or by a broken revert of #86954:

❯ nix-build -A python3.pkgs.cython
these derivations will be built:
  /nix/store/7kq52z55dhp44irxcz1j58yvv2x2k13r-python3.7-Cython-0.29.14.drv
building '/nix/store/7kq52z55dhp44irxcz1j58yvv2x2k13r-python3.7-Cython-0.29.14.drv'...
bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
/nix/store/8cz3waxwnvqd1mxw3aniiwimr8kvxbsg-python3.7-pkgconfig-1.5.1/nix-support/setup-hook: line 61: export: `NIX_@wrapperName@_TARGET_HOST_@suffixSalt@=1': not a valid identifier
builder for '/nix/store/7kq52z55dhp44irxcz1j58yvv2x2k13r-python3.7-Cython-0.29.14.drv' failed with exit code 1
error: build of '/nix/store/7kq52z55dhp44irxcz1j58yvv2x2k13r-python3.7-Cython-0.29.14.drv' failed
@vcunat
Copy link
Member

vcunat commented May 25, 2020

My "dumb" bisection showed

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
26f635d
42b2035
c71ab32
f29919d
4b2ab66
We cannot bisect more!

and all of that are his commits around pkgconf(ig), so I'd hope he might know easily what got wrong in particular.

@vcunat
Copy link
Member

vcunat commented May 25, 2020

Still, note that the error is not present in this PR, i.e. it's ATM in staging-next..staging.

@flokli flokli mentioned this pull request May 25, 2020
7 of 14 tasks complete
FRidh added 2 commits May 27, 2020
@FRidh FRidh merged commit b27a19d into master May 29, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers large change, skipping automatic review requests
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7d25a5"; rev="c7d25a5db6beb915be4dd714821f342fab7980a2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.