Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precice: 2020-01-20 -> 2.0.2 #87816

Merged
merged 1 commit into from Jun 2, 2020
Merged

precice: 2020-01-20 -> 2.0.2 #87816

merged 1 commit into from Jun 2, 2020

Conversation

@Scriptkiddi
Copy link
Contributor

Scriptkiddi commented May 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Scriptkiddi Scriptkiddi force-pushed the helsinki-systems:precice2 branch from 1c3d7c3 to 9aef2f0 May 14, 2020
@Scriptkiddi Scriptkiddi force-pushed the helsinki-systems:precice2 branch 3 times, most recently from 07afa75 to 56fce9c May 14, 2020
@srhb srhb marked this pull request as draft May 14, 2020
@Scriptkiddi Scriptkiddi marked this pull request as ready for review May 23, 2020
@Scriptkiddi Scriptkiddi force-pushed the helsinki-systems:precice2 branch from 56fce9c to 9d50563 May 23, 2020
@Lassulus
Copy link
Contributor

Lassulus commented May 26, 2020

is the binary meant to be named binprecice ?

@Scriptkiddi
Copy link
Contributor Author

Scriptkiddi commented Jun 2, 2020

yes

@Lassulus Lassulus merged commit 09da70f into NixOS:master Jun 2, 2020
16 checks passed
16 checks passed
precice, precice.passthru.tests on aarch64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d50563"; rev="9d50563293c2d405ad7205137105e3b71410a878"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
precice, precice.passthru.tests on x86_64-linux Success
Details
@Scriptkiddi Scriptkiddi deleted the helsinki-systems:precice2 branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.