Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skaffold to v1.9.1 #87826

Closed
wants to merge 1 commit into from
Closed

Update skaffold to v1.9.1 #87826

wants to merge 1 commit into from

Conversation

@dsyer
Copy link
Contributor

dsyer commented May 14, 2020

There is a new schema available in the YAML in 1.9 so this is needed to work with some of the new features. I believe you can still use the old schema.

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits [CONTRIBUTING.md] (think so - first time)(https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
There is a new schema available in the YAML in 1.9 so this is needed to work with some of the new features. I believe you can still use the old schema.
@dsyer dsyer force-pushed the dsyer:patch-1 branch from 3dab062 to d25d7a9 May 14, 2020
@dsyer dsyer closed this Jun 1, 2020
@dsyer dsyer mentioned this pull request Jun 1, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.