Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem-config.mathematical: add lasem to rpath #87832

Open
wants to merge 1 commit into
base: master
from

Conversation

@Twey
Copy link
Contributor

Twey commented May 14, 2020

Motivation for this change

Without this change, mathematical is broken, which breaks (presumably among other things) the asciidoctor-mathematical gem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Twey Twey force-pushed the Twey:fix-lasem-rpath branch from 9d93ad0 to 91b0b5d May 15, 2020
@Twey
Copy link
Contributor Author

Twey commented Jun 16, 2020

Bump!

@Twey
Copy link
Contributor Author

Twey commented Jun 16, 2020

@evils I think you might be interested in this one as well? As it's also to do with asciidoctor.

@evils
Copy link
Contributor

evils commented Jun 16, 2020

thanks but i was mostly interested in getting rid of a dangling symlink

this PR increases the closure size of asciidoctor
from 337247856 to 343880800

though it seems like with the closing of RFC 0064 ReST is the preferred format making this less of a concern

nixpkgs-review result:

3 packages failed to build:
- deepin.dde-file-manager
- deepin.startdde
- rabbitvcs
99 packages built:
- adapta-gtk-theme
- almanah
- asciidoctor
- atom
- atom-beta
- awesome
- bat-extras.batgrep
- btrbk
- calls
- cantata
- chrome-gnome-shell
- cinnamon.cinnamon-control-center
- clementine
- clementineUnfree
- deja-dup
- dropbox-cli
- elementary-planner
- empathy
- enlightenment.enlightenment
- esh
- evolution-data-server (evolution_data_server)
- far2l
- feedreader
- folks
- gfbgraph
- gnome-multi-writer
- gnome-online-accounts
- gnome-photos
- gnome-recipes
- gnome2.gvfs
- gnome3.bijiben
- gnome3.cheese
- gnome3.evolution
- gnome3.file-roller
- gnome3.geary
- gnome3.gnome-applets
- gnome3.gnome-books
- gnome3.gnome-boxes
- gnome3.gnome-calendar
- gnome3.gnome-contacts
- gnome3.gnome-control-center
- gnome3.gnome-disk-utility
- gnome3.gnome-documents
- gnome3.gnome-flashback
- gnome3.gnome-initial-setup
- gnome3.gnome-maps
- gnome3.gnome-music
- gnome3.gnome-online-miners
- gnome3.gnome-panel
- gnome3.gnome-session
- gnome3.gnome-shell
- gnome3.gnome-software
- gnome3.gnome-terminal
- gnome3.gnome-todo
- gnome3.gnome-tweak-tool
- gnome3.gnome-user-share
- gnome3.grilo-plugins
- gnome3.gvfs
- gnome3.libgdata
- gnome3.libzapojit
- gnome3.nautilus
- gnome3.nautilus-python
- gnome3.pomodoro
- gnome3.shotwell
- gnome3.totem
- gnome3.tracker-miners
- gnomeExtensions.gsconnect
- hal-flash
- libblockdev
- libndctl
- mate.mate-utils
- newsboat
- pantheon.elementary-calendar
- pantheon.elementary-greeter
- pantheon.elementary-session-settings
- pantheon.extra-elementary-contracts
- pantheon.wingpanel-indicator-datetime
- pantheon.wingpanel-with-indicators
- pmdk
- psensor
- rapid-photo-downloader
- ripgrep
- ripgrep-all
- spaceFM
- styx
- udiskie
- udisks
- usermount
- vifm-full
- weechat
- weechat-unwrapped
- wsjtx
- xfce.gigolo
- xfce.gvfs
- xfce.thunar (xfce.thunar-bare)
- xfce.thunar-archive-plugin
- xfce.thunar-dropbox-plugin
- xfce.xfdesktop
- xmonad_log_applet (xmonad_log_applet_gnome3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.