Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove uses of p7zip #87837

Draft
wants to merge 15 commits into
base: master
from
Draft

treewide: remove uses of p7zip #87837

wants to merge 15 commits into from

Conversation

@emilazy
Copy link
Member

emilazy commented May 14, 2020

Motivation for this change

Work in progress; part of the long follow-up to #86417. This is just focused on fixing derivations that use p7zip at build time rather than applications that use p7zip themselves.

cc @tstrobel; I couldn't manage to get the various win-* derivations that extract MSIs working, as I don't fully understand p7zip's behaviour here; it seems to collapse/ignore parts of the extracted hierarchy and do less extraction compared to msiextract. For example, is it really intended that ${pkgs.win-signed-gplpv-drivers}/amd64 mostly contains a bunch of installer metadata and a monolithic gplpv.cab file?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
emilazy added 15 commits May 14, 2020
This package has been broken since 2017, essentially untouched since
2014, and has no maintainers.

The last upstream release was in 2016; the download link for that
release is dead. Although i was able to download it via BitTorrent,
that sounds hard to integrate into NixOS. Additionally, the latest
phone the program works with was released in 2013, so I suspect the
demand is fairly minimal.

Given the amount of TODOs in the derivation and its long-broken state, I
conclude that any update of this package would likely be as much effort
as packaging it from scratch, and since nobody as stepped up to do so in
several years, it can be safely removed.
libarchive can't handle this `.7z` file:

    zdoom> unpacking sources
    zdoom> tools/re2c/CHANGELOG: Lzma library error: Invalid options
    zdoom> bsdtar: Error exit delayed from previous errors.
Hydra won't build this so it probably shouldn't be used to extract
derivation sources. libarchive is a suitable alternative.
@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Jun 11, 2020

Note: there is #90140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.