Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsboat: fix on darwin #87838

Merged
merged 1 commit into from May 14, 2020
Merged

newsboat: fix on darwin #87838

merged 1 commit into from May 14, 2020

Conversation

@sikmir
Copy link
Member

sikmir commented May 14, 2020

Motivation for this change

Changelog:

  1. Move libiconv from nativeBuildInputs to buildInputs, fixes:
./libxml/encoding.h:29:10: fatal error: 'iconv.h' file not found
#include <iconv.h>
         ^~~~~~~~~
1 error generated.
  1. Add ncurses to nativeBuildInputs, fixes:
Checking for package ncurses using ncurses-config... not found

You need package ncurses in order to compile this program.
Please make sure it is installed.
./config.sh: line 87: curl-config: command not found
./config.sh: line 91: curl-config: command not found
  1. Add gettext to buildInputs, fixes:
In file included from src/configcontainer.cpp:10:
./config.h:15:10: fatal error: 'libintl.h' file not found
#include <libintl.h>
         ^~~~~~~~~~~
1 error generated.
  1. Fix prefix, otherwise newsboat searches for translations in /usr/local/share
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dywedir @doronbehar

@dywedir
Copy link
Contributor

dywedir commented May 14, 2020

Thank you!

@dywedir dywedir merged commit 9732342 into NixOS:master May 14, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1316637"; rev="131663718e97f26583d8f80d068888f8dc0591d8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
newsboat, newsboat.passthru.tests on aarch64-linux Success
Details
newsboat, newsboat.passthru.tests on x86_64-linux Success
Details
@sikmir sikmir deleted the sikmir:newsboat branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.