Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tamzen: init at 1.11.4 #87842

Merged
merged 2 commits into from May 24, 2020
Merged

tamzen: init at 1.11.4 #87842

merged 2 commits into from May 24, 2020

Conversation

@wishfort36
Copy link
Contributor

wishfort36 commented May 14, 2020

Motivation for this change

Tamsyn is a cool font, but it doesn't have a powerline version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

most fonts also use fetchzip, as you don't really need a stdenv. Althought the otb creation may warrant otherwise

cc @rnhmjoj

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/data/fonts/tamzen/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented May 15, 2020

also, thanks for opening your first PR

Copy link
Contributor

rnhmjoj left a comment

The package looks good. I still have to test the .otb fonts: fontforge doesn't always produce good results.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 16, 2020

Tested the otb fonts in urxvt and they seem all right.

@wishfort36
Copy link
Contributor Author

wishfort36 commented May 16, 2020

I've done the requested changes. Thanks for reviewing, I'm not well versed with Nix, so I at first packaged tamzen for it to just work.

also, thanks for opening your first PR

Thanks! I'm trying NixOS and found that it didn't package the coolest font I know of, so I felt that I had to contribute.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 18, 2020

Can you squash the subsequent changes to tamzen in a single commit?

If you have never done it before you can do it like this:

  • Run git rebase -i HEAD~5,
  • Then reorder the commits and use the fixup action
  • save, exit and fix the conflicts if necessary

You should keep two commits:

  1. maintainers: add wishfort36
  2. tamzen: init at 1.11.4
@wishfort36 wishfort36 force-pushed the wishfort36:tamzen-1.11.4 branch from 698a1b6 to c7551f4 May 18, 2020
@wishfort36
Copy link
Contributor Author

wishfort36 commented May 23, 2020

Done.

@rnhmjoj rnhmjoj merged commit 21537c4 into NixOS:master May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7551f4"; rev="c7551f47c2798854d0136e7e2b709f97c710fd2b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tamzen, tamzen.passthru.tests on aarch64-linux Success
Details
tamzen, tamzen.passthru.tests on x86_64-linux Success
Details
@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 24, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.