Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomachine-client: Add archive.org to source urls #87843

Merged
merged 1 commit into from May 15, 2020

Conversation

@talyz
Copy link
Contributor

talyz commented May 14, 2020

Motivation for this change

NoMachine removes each old release as soon as a new one is available, resulting in failed downloads. Thankfully, the Internet Archive provides backups of old downloads, so we can use it as a fallback.

cc @austinbutler @amahoneyLIT

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
NoMachine removes each old release as soon as a new one is available,
resulting in failed downloads. Thankfully, the Internet Archive
provides backups of old downloads, so we can use it as a fallback.
@talyz talyz requested a review from megheaiulian May 14, 2020
@talyz talyz merged commit ecb1d7d into NixOS:master May 15, 2020
16 checks passed
16 checks passed
nomachine-client, nomachine-client.passthru.tests on aarch64-linux No attempt
Details
nomachine-client, nomachine-client.passthru.tests on x86_64-darwin No attempt
Details
nomachine-client, nomachine-client.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="022f2cc"; rev="022f2cc02f75ea44f96d1a7174e6da3d612a4b01"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@talyz talyz deleted the talyz:nomachine-archive branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.