Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotify: adapt update script to use vendor sha #87849

Merged
merged 1 commit into from May 14, 2020

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 14, 2020

Motivation for this change

Adapt update script and derivation to use vendor sha etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -11,9 +11,9 @@ echo got version $version
echo \""${version#v}"\" > "$dirname/version.nix"
printf '%s' $(nix-prefetch-git --quiet --rev ${version} https://github.com/gotify/server | jq .sha256) > $dirname/source-sha.nix
tput setaf 1
echo zeroing modSha256 in $dirname/mod-sha.nix
echo zeroing vendorSha256 in $dirname/vendor-sha.nix

This comment has been minimized.

Copy link
@Mic92

Mic92 May 14, 2020

Contributor

By the way, you can also use nix-prefetch or nix-update itself for tasks like this.

This comment has been minimized.

Copy link
@Mic92

Mic92 May 14, 2020

Contributor

Saves a few lines of code.

This comment has been minimized.

Copy link
@doronbehar

doronbehar May 14, 2020

Author Contributor

You mean with the --fetcher argument?

This comment has been minimized.

Copy link
@Mic92

Mic92 May 14, 2020

Contributor

You just need to pass a nix function as string to nix-prefetch: https://github.com/Mic92/nix-update/blob/master/nix_update/update.py#L37

@Mic92
Copy link
Contributor

Mic92 commented May 14, 2020

Result of nixpkgs-review pr 87849 1

@Mic92 Mic92 merged commit fc03905 into NixOS:master May 14, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5746259"; rev="5746259af694fc791743c322f2cf0d47e3d0d9bd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.