Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.14.2 -> 1.14.3 #87851

Merged
merged 1 commit into from May 19, 2020
Merged

go: 1.14.2 -> 1.14.3 #87851

merged 1 commit into from May 19, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 14, 2020

https://golang.org/doc/devel/release.html#go1.14.minor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@c00w
c00w approved these changes May 15, 2020
Copy link
Contributor

c00w left a comment

Looks good to me - waiting for nix-review pr to finish, but given the minor bump I would be surprised if it failed.

@Frostman
Copy link
Member

Frostman commented May 15, 2020

Seems no new failures, mainly not related to the Go update IMO.

nixpkgs-review pr results:

7 package marked as broken and skipped:
dcrd dcrwallet meguca packetbeat packetbeat6 rkt storebrowse

43 package failed to build:
aerc bat-extras.prettybat bazel-remote bazel-watcher coyim datadog-agent deepin.dbus-factory deepin.dde-api deepin.dde-control-ce$
ter deepin.dde-daemon deepin.dde-dock deepin.dde-file-manager deepin.dde-kwin deepin.dde-launcher deepin.dde-session-ui deepin.de$
pin-desktop-base deepin.deepin-desktop-schemas deepin.deepin-wallpapers deepin.go-dbus-generator deepin.startdde dep2nix gocryptf$
gvisor hound imgproxy minishift onionshare onionshare-gui out-of-tree pond prometheus-varnish-exporter syncthing-gtk python37Pac$
ages.jupyter-repo2docker python38Packages.jupyter-repo2docker qmk_firmware sourcehut.buildsrht sourcehut.gitsrht sourcehut.hgsrht
styx vimPlugins.YouCompleteMe xmloscopy ycmd zoxide

773 package built

@marsam marsam merged commit 760aa78 into NixOS:staging May 19, 2020
16 checks passed
16 checks passed
go, go.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
go, go.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d41f9f"; rev="8d41f9f281a8317faa45c4270e8d48bf657cc1a0"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:go1143 branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.