Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-neb: Init at unstable-2020-04-09 #87854

Merged
merged 2 commits into from May 28, 2020
Merged

go-neb: Init at unstable-2020-04-09 #87854

merged 2 commits into from May 28, 2020

Conversation

@maralorn
Copy link
Contributor

maralorn commented May 15, 2020

Motivation for this change

Adds a package for the go-neb matrix bot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt

This comment was marked as outdated.

@Gaelan
Copy link
Contributor

Gaelan commented May 15, 2020

Builds successfully on Darwin.

@mweinelt
Copy link
Member

mweinelt commented May 15, 2020

This pr is currently rebased on #87855 and should be merged after that.

@maralorn maralorn force-pushed the maralorn:go-neb branch from 861ef91 to a18466b May 24, 2020
@maralorn
Copy link
Contributor Author

maralorn commented May 24, 2020

I have reverted the dependency on #87855 because that PR got rejected. It now uses the old patch method for the modfile again.

@mweinelt
Copy link
Member

mweinelt commented May 24, 2020

Result of nixpkgs-review pr 87854 1

1 package built:
- go-neb
@nixos-discourse
Copy link

nixos-discourse commented May 27, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/170

@bbigras
Copy link
Contributor

bbigras commented May 28, 2020

Result of nixpkgs-review pr 87854 1

1 package built:
- go-neb
@bbigras
Copy link
Contributor

bbigras commented May 28, 2020

Builds and runs fine. Tested with a real notification from alertmanager/prometheus to a room on matrix.org. Thanks for the PR!

@nixos-discourse
Copy link

nixos-discourse commented May 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/173

@kalbasit
Copy link
Member

kalbasit commented May 28, 2020

@GrahamcOfBorg build go-neb

Copy link
Member

kalbasit left a comment

Otherwise LGTM. Please address my comment and I can merge it

@maralorn maralorn force-pushed the maralorn:go-neb branch from ea167dd to 766c337 May 28, 2020
@maralorn
Copy link
Contributor Author

maralorn commented May 28, 2020

@kalbasit Done

@ofborg ofborg bot requested a review from kalbasit May 28, 2020
@kalbasit
Copy link
Member

kalbasit commented May 28, 2020

@GrahamcOfBorg build go-neb

@kalbasit kalbasit merged commit 7d416ce into NixOS:master May 28, 2020
19 checks passed
19 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
go-neb on aarch64-linux Success
Details
go-neb on x86_64-darwin Success
Details
go-neb on x86_64-linux Success
Details
go-neb, go-neb.passthru.tests on aarch64-linux Success
Details
go-neb, go-neb.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="766c337"; rev="766c3374454fc52be91212c3f67ddd3a06e3277b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bbigras
Copy link
Contributor

bbigras commented May 28, 2020

@maralorn any plans for a nixos module?

@mweinelt
Copy link
Member

mweinelt commented May 28, 2020

@bbigras Yep, we intend to write that tonight(TM).

@bbigras
Copy link
Contributor

bbigras commented May 28, 2020

Sweet, thanks!

@maralorn maralorn deleted the maralorn:go-neb branch May 29, 2020
@mweinelt mweinelt mentioned this pull request Jun 2, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.