Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todoman: Make it not reference glibLocale which is ~210Mb in closure size #87864

Open
wants to merge 2 commits into
base: master
from

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 15, 2020

Motivation for this change

todoman references glibLocales which is ~210Mb in size. This PR removes this reference. I have no idea why the original maintainer has reached the conclusion it is needed. I tested it thoroughly and everything seems ok without the wrapping which I removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
doronbehar added 2 commits Apr 26, 2020
Don't know why they were there in the first place :/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.