Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validatePkgConfig: init #87866

Merged
merged 2 commits into from Jun 3, 2020
Merged

validatePkgConfig: init #87866

merged 2 commits into from Jun 3, 2020

Conversation

@danieldk
Copy link
Member

danieldk commented May 15, 2020

Motivation for this change

This adds the validatePkgConfig hook, which can be used to validate
pkg-config files in the output(s). Currently, this will just run
pkg-config --validate on all .pc files, capturing errors such as
the issue that was fixed in #87789.

The hook could be extended in the future with more fine-grained
checks.

I have also added a commit which enables this hook for the MKL derivation as an example.

This is the first time I touched the hooks at all, so I hope I didn't do anything bad ;).

@bhipple

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk danieldk requested a review from Ericson2314 as a code owner May 15, 2020
@ofborg ofborg bot requested a review from bhipple May 15, 2020
@danieldk danieldk force-pushed the danieldk:validate-pkgconfig-hook branch from 99515a0 to 7b5f8f4 May 15, 2020
@danieldk
Copy link
Member Author

danieldk commented May 31, 2020

Seems like this PR sunk down the list ;). Any comments @bhipple ?

danieldk added 2 commits May 15, 2020
This adds the `validatePkgConfig` hook, which can be used to validate
pkg-config files in the output(s). Currently, this will just run
`pkg-config --validate` on all `.pc` files, capturing errors such as
the issue that was fixed in #87789.

The hook could be extended in the future with more fine-grained
checks.
@danieldk danieldk force-pushed the danieldk:validate-pkgconfig-hook branch from 7b5f8f4 to 127cdd0 May 31, 2020
@bhipple
bhipple approved these changes Jun 3, 2020
@bhipple
Copy link
Contributor

bhipple commented Jun 3, 2020

Result of nixpkgs-review pr 87866 1

6 packages built:
- clmagma
- mkl
- python27Packages.mkl-service
- python37Packages.mkl-service
- python38Packages.mkl-service
- validatePkgConfig
@bhipple
bhipple approved these changes Jun 3, 2020
@bhipple bhipple merged commit 4af635f into NixOS:master Jun 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="127cdd0"; rev="127cdd0cab64405fff28d8668d3f416c979406d4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mkl, mkl.passthru.tests, validatePkgConfig, validatePkgConfig.passthru.tests on aarch64-linux Success
Details
mkl, mkl.passthru.tests, validatePkgConfig, validatePkgConfig.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.