Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palemoon: 28.9.1 -> 28.9.3 #87868

Merged
merged 1 commit into from Jun 4, 2020
Merged

palemoon: 28.9.1 -> 28.9.3 #87868

merged 1 commit into from Jun 4, 2020

Conversation

@OPNA2608
Copy link
Contributor

OPNA2608 commented May 15, 2020

Motivation for this change

Security update, will backport to 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

drewrisinger left a comment

  • Diff LGTM.
  • Builds via OfBorg
  • Doesn't build locally. Issue is related to my build machine, says it runs out of space (Ubuntu 18.04, not NixOS, >200 GB free, had similar issues on other succeeding builds). Approving despite this.

Error message for future reference:

IOError: [Errno 28] No space left on device
  
    File "/build/Pale-Moon/platform/python/mozbuild/mozbuild/mach_commands.py", line 459, in build
      monitor.finish(record_usage=status==0)
    File "/build/Pale-Moon/platform/python/mozbuild/mozbuild/controller/building.py", line 255, in finish
      self.warnings_database.save_to_file(self._warnings_path)
    File "/build/Pale-Moon/platform/python/mozbuild/mozbuild/compilation/warnings.py", line 279, in save_to_file
      self.serialize(fh)
note: build failure may have been caused by lack of free disk space
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 28, 2020

Can't reproduce, sorry. Testing on Ubuntu 18.04 myself - alot less free disk space on root than you (<60GiB free), 6GiB RAM, 3 build cores. I'm more than 40min in and the build looks like it's about to succeed just succeeded, how curious.

@nixos-discourse
Copy link

nixos-discourse commented Jun 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/175

@hrdinka hrdinka merged commit 001cf3f into NixOS:master Jun 4, 2020
16 checks passed
16 checks passed
palemoon, palemoon.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5262ada"; rev="5262ada436fb89d6d259f242ad6440a83dbef8f1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
palemoon, palemoon.passthru.tests on x86_64-linux Success
Details
@hrdinka
Copy link
Contributor

hrdinka commented Jun 4, 2020

Thanks for the update 👍

@OPNA2608 OPNA2608 mentioned this pull request Jun 6, 2020
1 of 10 tasks complete
@ajs124
Copy link
Member

ajs124 commented Jun 8, 2020

@drewrisinger are you maybe building on /tmp with a tmpfs there?

@drewrisinger
Copy link
Contributor

drewrisinger commented Jun 8, 2020

@drewrisinger are you maybe building on /tmp with a tmpfs there?

I think I'm building in /tmp but not sure about tmpfs. I'll check sometime. Thanks for help w/ debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.