Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctor: add asciidoctor-bibliography #87882

Open
wants to merge 2 commits into
base: master
from

Conversation

@Twey
Copy link
Contributor

Twey commented May 15, 2020

(change via bundix)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Twey added 2 commits May 15, 2020
@evils
Copy link
Contributor

evils commented May 15, 2020

this should probably be merged to staging (i'm switching my #87646 to that now)

i haven't tried the result, but since i think closure size was a concern for NixOS/rfcs#64, this takes asciidoctor's nix path-info -S from 337247856 to 374326416

@evils
Copy link
Contributor

evils commented May 15, 2020

apparently i spoke too soon and staging is recommended for PRs that rebuild >1000 packages

@Twey
Copy link
Contributor Author

Twey commented Jun 8, 2020

So should this be onto staging? 🤔

@evils
Copy link
Contributor

evils commented Jun 8, 2020

So should this be onto staging?

i've been told otherwise
i was thinking it may be useful to not rebuild the dependents twice
but my PR is separate enough from this that they're not likely to be merged around the same time anyway

@Twey
Copy link
Contributor Author

Twey commented Jun 16, 2020

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.