Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fly: 6.0.0 -> 6.1.0 #87885

Merged
merged 2 commits into from May 15, 2020
Merged

fly: 6.0.0 -> 6.1.0 #87885

merged 2 commits into from May 15, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 15, 2020

Motivation for this change

This bumps fly to the latest release, containing various fixes as described in https://github.com/concourse/concourse/releases/tag/v6.1.0.

We also stop shipping the bash completions in the nixpkgs tree and generate them during the build, as concourse/concourse#4012 was merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
There's no need to ship the pre-generated completions in the nixpkgs
tree anymore.
Copy link
Contributor

edibopp left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64, NixOS fails
  • executables tested on x86_64, NixOS fails
  • all depending packages build
Possible improvements
Comments

As commented in the code the vendorSha256 hash is all zeros, which has to be changed to the actual hash of the vendored dependencies.

@flokli flokli force-pushed the flokli:fly-6.1.0 branch from 9c45bec to 44c0533 May 15, 2020
@flokli flokli requested a review from edibopp May 15, 2020
Copy link
Contributor

edibopp left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64, NixOS
  • executables tested on x86_64, NixOS
  • all depending packages build
Possible improvements

none

Comments

Now it's all good! :)

I checked execution of fly on its own and the completion functionality specifically both in zsh and bash like that:

source <(fly completion --shell zsh)
fly <TAB>

and I get a nice list of commands as completions.

@flokli flokli merged commit b611581 into NixOS:master May 15, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
fly, fly.passthru.tests on aarch64-linux Success
Details
fly, fly.passthru.tests on x86_64-darwin Success
Details
fly, fly.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44c0533"; rev="44c053349758fff67f67dbc61f2bb27968c1135e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli flokli deleted the flokli:fly-6.1.0 branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.