Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.bleak: init at 0.6.2 #87886

Merged
merged 2 commits into from May 19, 2020
Merged

pythonPackage.bleak: init at 0.6.2 #87886

merged 2 commits into from May 19, 2020

Conversation

@geistesk
Copy link
Member

geistesk commented May 15, 2020

Motivation for this change

Adds bleak and its dependency txdbus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@geistesk geistesk requested review from FRidh and jonringer as code owners May 15, 2020
@geistesk geistesk force-pushed the geistesk:bleak branch from 68f0066 to fce04dd May 15, 2020
@geistesk geistesk changed the title pythonPackage.bleak: init at 0.5.1 pythonPackage.bleak: init at 0.6.2 May 15, 2020
@geistesk geistesk force-pushed the geistesk:bleak branch from fce04dd to 6aefb13 May 15, 2020
@geistesk geistesk force-pushed the geistesk:bleak branch from 6aefb13 to 070294b May 15, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87886 1

5 packages built: - python27Packages.txdbus - python37Packages.bleak - python37Packages.txdbus - python38Packages.bleak - python38Packages.txdbus

@jonringer jonringer merged commit 738df6f into NixOS:master May 19, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="070294b"; rev="070294be97334a8af5199d927a700da4be4900b7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@geistesk geistesk deleted the geistesk:bleak branch May 19, 2020
@geistesk geistesk restored the geistesk:bleak branch May 19, 2020
@geistesk geistesk deleted the geistesk:bleak branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.