Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: enable soxr (resampler) support #87889

Merged
merged 1 commit into from May 24, 2020
Merged

Conversation

@pbogdan
Copy link
Member

pbogdan commented May 15, 2020

Motivation for this change

Support for additional resamplers.

Things done

Been running this on my system for a good while. The closure size increase is marginal (79.1M → 79.4M).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pbogdan
Copy link
Member Author

pbogdan commented May 15, 2020

Copy link
Member

emilazy left a comment

Thanks, I'd wondered about the unavailability of these before.

@adisbladis adisbladis merged commit 4a5a9d2 into NixOS:staging May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e7d4b31"; rev="e7d4b315daf79752a1d6df1754395f68fdb90484"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pulseaudio, pulseaudio.passthru.tests on aarch64-linux Success
Details
pulseaudio, pulseaudio.passthru.tests on x86_64-linux Success
Details
@pbogdan pbogdan deleted the pbogdan:pa-soxr branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.