Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitnesstrax: derivation bugfix #87890

Merged
merged 1 commit into from Jun 7, 2020

Conversation

@savannidgerinel
Copy link
Contributor

savannidgerinel commented May 15, 2020

Motivation for this change

Make sure glib and gtk3 are both in nativeBuildInputs

I don't know why this didn't break before, but glib and (or) gtk3 need
to be in nativeBuildInputs for glib-compile-schemas to be available. But
they also need to be in buildInputs to be available at link time.

I think worldofpeace mentioned this to me, but that it got lost in all
of the other fixes I needed to make when I first submitted the
derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
I don't know why this didn't break before, but glib and (or) gtk3 need
to be in nativeBuildInputs for glib-compile-schemas to be available. But
they also need to be in buildInputs to be available at link time.

I think worldofpeace mentioned this to me, but that it got lost in all
of the other fixes I needed to make when I first submitted the
derivation.
@FRidh FRidh merged commit af13724 into NixOS:master Jun 7, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d3e298"; rev="7d3e2984ff5a0297c53965de0f438bbee3beedee"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.