Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvn: Wrap mvnDebug for convenience #87894

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

@bessonm
Copy link
Contributor

bessonm commented May 15, 2020

ref: #65278

Since maven 2.0.8, it is shipped with a debugger, mvnDebug, which is sometimes useful.
Wrapping it is more convenient for use, instead of looking for it in the nix store.

Things done
  • Built on :

    • NixOS
    • macOS
  • Tested :

  • Tested using nix-env -f ~/sources/nixpkgs/ -iA maven, then calling mvnDebug.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title maven: Wrap mvnDebug for convenience mvn: Wrap mvnDebug for convenience May 15, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 15, 2020

Copy link
Contributor

edibopp left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on NixOS x86_64
  • executables tested on NixOS x86_64
  • all depending packages build: not all (marathon, mesos and chronos fail), but I believe mesos is currently broken anyway and I see no relation to this change
@Mic92 Mic92 merged commit 8dae16c into NixOS:master May 19, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77ec372"; rev="77ec372a3faf44c929dcb27b0590b8b51317c0be"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
maven, maven.passthru.tests on aarch64-linux Success
Details
maven, maven.passthru.tests on x86_64-linux Success
Details
@Mic92
Copy link
Contributor

Mic92 commented May 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.