Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-desktop: 1.0.201 -> 1.0.207 #87898

Closed
wants to merge 1 commit into from

Conversation

@CheariX
Copy link
Contributor

CheariX commented May 15, 2020

Motivation for this change

New version release. (Edit: 1.0.207 is a pre-release)
Simply chaged version and hash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124
ajs124 approved these changes May 15, 2020
@ajs124
Copy link
Member

ajs124 commented May 15, 2020

One thing to note is that this comes with a new WYSIWYG editor, which is enabled by default, but for evaluation only. Finding the button to switch back to the regular old view wasn't the easiest to locate.

And it upgrades your database, so you can't run the older version, after you've run this one, against the same profile.

Copy link
Contributor

HugoReeves left a comment

Built successfully on NixOS. LGTM

@ajs124
Copy link
Member

ajs124 commented May 18, 2020

Upstream is up to 1.0.209 now, although everything after 1.0.201 is marked as pre-release.

@CheariX
Copy link
Contributor Author

CheariX commented May 18, 2020

I did not see the pre release label.
Sorry for that.

If you prefer, simply deny this PR.

@HugoReeves HugoReeves closed this May 18, 2020
@HugoReeves
Copy link
Contributor

HugoReeves commented May 18, 2020

Closed as the pre-release label for 1.0.209 is correct. Thanks @CheariX for your PR, once a new release is available we will look to package it.
@raquelgb Are you still interested in maintaining joplin-desktop?
There have been some issues in getting updates merged as you are usually attached as the reviewer of the PR, but it seems you are often inactive on GitHub. Any clarity would be much appreciated, thanks.

@CheariX CheariX deleted the CheariX:joplin-desktop-1.0.207 branch May 19, 2020
@CheariX CheariX mentioned this pull request May 27, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.