Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] megasync 4.2.3.0 -> 4.3.0.9 (backport) #87901

Merged
merged 3 commits into from May 16, 2020

Conversation

@lunik1
Copy link
Contributor

lunik1 commented May 15, 2020

Motivation for this change

Megasync does not currently build on 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Synthetica9 added 3 commits Feb 26, 2020
(cherry picked from commit 5e55ebb)
Also pull in an (as of yet unmerged) upstream patch to fix
the build, it was failing on both .3 and .5

(cherry picked from commit 080a6b0)
(cherry picked from commit 8565dcf)
Copy link
Contributor

michojel left a comment

LGTM
built and tested

@marsam marsam merged commit 8c1977c into NixOS:release-20.03 May 16, 2020
16 checks passed
16 checks passed
megasync, megasync.passthru.tests on aarch64-linux No attempt
Details
megasync, megasync.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a83fa4"; rev="2a83fa476a8eb3df363eec4e4a9f0dc2960b402a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.