Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobject-introspection: clean-ups & build docs #87904

Merged
merged 5 commits into from May 23, 2020
Merged

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented May 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jtojnar added 4 commits May 15, 2020
* format with nixpkgs-fmt
* reorder the attributes
* use pkg-config instead of the pkgconfig alias
* optional → optionals
* remove top-level `with lib;`
* remove glibcLocales now that glibc contains C.UTF-8
* remove libintl, that should be in by default or something
* update homepage
* add gnome team to maintainers
* remove the temporary libregress closer its creation
and add comments
@jtojnar
Copy link
Contributor Author

jtojnar commented May 17, 2020

@GrahamcOfBorg build gobject-introspection

1 similar comment
@jtojnar
Copy link
Contributor Author

jtojnar commented May 17, 2020

@GrahamcOfBorg build gobject-introspection

];

buildInputs = [
flex
bison
python3

This comment has been minimized.

Copy link
@Mic92

Mic92 May 18, 2020

Contributor

cc @FRidh from a cross-compiling perspective we usually used the build-native python interpreter to build python packages, no?

This comment has been minimized.

Copy link
@FRidh

FRidh May 20, 2020

Member

yes, the build-native one is used in buildPythonPackage.

This comment has been minimized.

Copy link
@FRidh

FRidh May 20, 2020

Member

maybe they link against the interpreter, that is, use the C API?

This comment has been minimized.

Copy link
@jtojnar

jtojnar May 20, 2020

Author Contributor

Build scripts need build python and some gobject utils are written in python so they need host python.

docbook_xml_dtd_45
python3

This comment has been minimized.

Copy link
@Mic92

Mic92 May 18, 2020

Contributor

Ah. It's in both. That would be fine I suppose.

@jtojnar jtojnar mentioned this pull request May 20, 2020
0 of 10 tasks complete
@jtojnar
Copy link
Contributor Author

jtojnar commented May 20, 2020

@GrahamcOfBorg build gobject-introspection

@Ericson2314
Copy link
Member

Ericson2314 commented May 21, 2020

liblibarchive builds now

@jtojnar
Copy link
Contributor Author

jtojnar commented May 21, 2020

1 similar comment
@jtojnar
Copy link
Contributor Author

jtojnar commented May 21, 2020

@Ericson2314
Copy link
Member

Ericson2314 commented May 23, 2020

I just built x86_64 linux and darwin.

@Ericson2314 Ericson2314 merged commit 5aad832 into NixOS:staging May 23, 2020
20 of 22 checks passed
20 of 22 checks passed
gobject-introspection on x86_64-darwin
Details
gobject-introspection, gobject-introspection.passthru.tests on x86_64-darwin
Details
(unknown attributes) on x86_64-darwin No attempt
Details
gobject-introspection on aarch64-linux Failure
Details
gobject-introspection on x86_64-linux Failure
Details
gobject-introspection, gobject-introspection.passthru.tests on aarch64-linux Failure
Details
gobject-introspection, gobject-introspection.passthru.tests on x86_64-linux Failure
Details
gobject-introspection.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c9857de"; rev="c9857dee7db3e77fbcee0eab8626d6b9ba100e25"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:gi-docs branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.