Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php72: 7.2.29 -> 7.2.31 #87905

Closed
wants to merge 2 commits into from
Closed

php72: 7.2.29 -> 7.2.31 #87905

wants to merge 2 commits into from

Conversation

@etu
Copy link
Contributor

@etu etu commented May 15, 2020

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.2.30

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This refs #85427

@etu
Copy link
Contributor Author

@etu etu commented May 15, 2020

cc @NixOS/php

@ofborg build php72

@talyz talyz changed the title php72: 7.2.29 -> 7.2.30 php72: 7.2.29 -> 7.2.31 May 16, 2020
@talyz
Copy link
Contributor

@talyz talyz commented May 16, 2020

@GrahamcOfBorg build php72

@talyz
Copy link
Contributor

@talyz talyz commented May 16, 2020

Hm, we get two test failures on aarch64.. Wonder if it's us or upstream; either way, we should probably disable the tests for php72 on aarch64.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 17, 2020

@Izorkin @talyz did you find out why the build is broken on aarch64?

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 17, 2020

@GrahamcOfBorg build php72.unwrapped

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 17, 2020

@GrahamcOfBorg build php72

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 17, 2020

Error build plugin php72Extensions.intl.
I have no way to testing build on architecture aarch64-linux and x86_64-darwin.

And need replace --with-libxml

diff --git a/pkgs/development/interpreters/php/default.nix b/pkgs/development/interpreters/php/default.nix
index b56824c7723..075d6af1bd4 100644
--- a/pkgs/development/interpreters/php/default.nix
+++ b/pkgs/development/interpreters/php/default.nix
@@ -176,7 +176,7 @@ let
             ++ lib.optional (!cgiSupport) "--disable-cgi"
             ++ lib.optional (!cliSupport) "--disable-cli"
             ++ lib.optional fpmSupport    "--enable-fpm"
-            ++ lib.optional pearSupport [ "--with-pear=$(out)/lib/php/pear" "--enable-xml" "--with-libxml" ]
+            ++ lib.optional pearSupport [ "--with-pear=$(out)/lib/php/pear" "--enable-xml" "--with-libxml-dir=${libxml2.dev}" ]
             ++ lib.optional (pearSupport && (lib.versionOlder version "7.4")) "--enable-libxml"
             ++ lib.optional pharSupport   "--enable-phar"
             ++ lib.optional phpdbgSupport "--enable-phpdbg"

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 17, 2020

I have no way to testing build on architecture aarch64-linux and x86_64-darwin.

Have you considered adding a PR here to gain access to some aarch64 infra: https://github.com/nix-community/aarch64-build-box/

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 17, 2020

I have no way to testing build on architecture aarch64-linux and x86_64-darwin.

Have you considered adding a PR here to gain access to some aarch64 infra: https://github.com/nix-community/aarch64-build-box/

Is there a similar variant for x86_64-darwin architecture?

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 22, 2020

Is there a similar variant for x86_64-darwin architecture?

AFAICS no. But fixing aarch64 would still be a step forward.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 25, 2020

Superseded by #91495.

@Ma27 Ma27 closed this Jun 25, 2020
@etu etu deleted the etu:php72-update branch Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.