Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/calibre-server: Allow multiple libraries, add "user" and "group" options #87912

Open
wants to merge 2 commits into
base: master
from

Conversation

@loewenheim
Copy link
Contributor

loewenheim commented May 15, 2020

Motivation for this change
  • Enabled more than one library directory. The option has been renamed from libraryDir to libraries. The motivation for this is simply that calibre-server supports it and I would like to have it.
  • There are now options to set the user and group the server should run under. If the standard user calibre-server is used, a home directory is created for it at /var/lib/calibre-server. The motivation for this change is the fact that there is currently no documentation about the user the server will run under and how this interacts with the library directory, as well as the fact that other similar server modules support setting the user and group.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@loewenheim loewenheim force-pushed the loewenheim:calibre-server branch from 8709ce4 to 9060a41 May 18, 2020
@loewenheim
Copy link
Contributor Author

loewenheim commented May 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.