Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH #87913

Merged
merged 2 commits into from May 16, 2020
Merged

go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH #87913

merged 2 commits into from May 16, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 16, 2020

This hook is removed in a1e13f6 on staging.

cc @Mic92 @zimbatm

@ofborg ofborg bot added the 6.topic: golang label May 16, 2020
@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

I'll bump it to 1.13.11 as well while we're here.

@cole-h
Copy link
Member

cole-h commented May 16, 2020

The hook is removed only in staging because it causes lots of rebuilds (which is what staging is for). It will make its way into master eventually.

EDIT: #87758

I was mistaken :D

@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

When staging merges to master go_1_13 will break as it was readded after the hook was deleted.

@zowoq zowoq force-pushed the zowoq:go113 branch from d6b065a to d1e7b00 May 16, 2020
@zowoq zowoq changed the title go: stop setting GOPATH go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH May 16, 2020
@ofborg ofborg bot requested review from Frostman, kalbasit, cstrahan and Mic92 May 16, 2020
@cole-h
Copy link
Member

cole-h commented May 16, 2020

I missed that this was for 1.13, oops.

I thought this would have a large amount rebuilds, but I remembered we migrated away from 1.13 (so nothing should be depending on a previously-removed package...). You're right; thanks for correcting me!

@zimbatm zimbatm merged commit 9fbb82f into NixOS:master May 16, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
go_1_13, go_1_13.passthru.tests on aarch64-linux Success
Details
go_1_13, go_1_13.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d1e7b00"; rev="d1e7b0049ca5bfb48a3fd597278acdc5b97b700f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:go113 branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.