Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.@nestjs/cli: init at 7.2.0 #87918

Merged
merged 1 commit into from Jun 19, 2020
Merged

nodePackages.@nestjs/cli: init at 7.2.0 #87918

merged 1 commit into from Jun 19, 2020

Conversation

@leungbk
Copy link

leungbk commented May 16, 2020

Motivation for this change

Add nestjs/cli, a NPM package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@leungbk leungbk force-pushed the leungbk:nestjs branch from 410aa20 to 9cc1f78 May 16, 2020
@leungbk leungbk changed the title nodePackages_10_x.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.0.13 May 17, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after merging #89184

@leungbk
Copy link
Author

leungbk commented May 30, 2020

@prusnak OK, I resolved the merge conflict.

@leungbk leungbk changed the title nodePackages.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.2.0 May 30, 2020
@leungbk leungbk force-pushed the leungbk:nestjs branch from 4b767d4 to 195b003 Jun 3, 2020
@ofborg ofborg bot removed the 10.rebuild-darwin: 1 label Jun 3, 2020
@leungbk
Copy link
Author

leungbk commented Jun 3, 2020

@prusnak I've resolved the merge conflict again. If there are any obstacles to this getting merged, please let me know.

@leungbk leungbk force-pushed the leungbk:nestjs branch from 195b003 to 9f18a84 Jun 9, 2020
@leungbk
Copy link
Author

leungbk commented Jun 9, 2020

@leungbk
Copy link
Author

leungbk commented Jun 19, 2020

@prusnak
Copy link
Member

prusnak commented Jun 19, 2020

@leungbk I don't have merge permissions for this repo. Your PR needs to be merged by someone who has them.

@alyssais alyssais merged commit 36572ae into NixOS:master Jun 19, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51e4292"; rev="51e42925b4d2c84ac94d2cd86530efd3318cc5bf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.