Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/CODEOWNERS: add podman team #87926

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 16, 2020

Until ofborg notifies maintainers for nixos/* this seems to be the alternative.

cc @NixOS/podman

Copy link
Member

saschagrunert left a comment

LGTM

@adisbladis adisbladis merged commit e5415d1 into NixOS:master May 16, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89b6d5f"; rev="89b6d5f175e276acdacfdaee2b0bb2e141076ab9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:codeowners-podman branch May 16, 2020
@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

This doesn't seem to work.

I'm hoping it just needs the nixpkgs repo to be added to the team* and not that the team needs commit access to be a codeowner?

*I've been asking for this to be done here: #84177 (comment)

@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2020

The team needs write access to the repo for this to work. PR to revert #89024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.