Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shamilton to maintainers #87935

Closed

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

SCOTT-HAMILTON commented May 16, 2020

Motivation for this change

Wasn't yet on the maintainers list.

Things done

Added Scott Hamilton aka me to the list.

Scott Hamilton added 2 commits May 15, 2020
Scott Hamilton
@wamserma
Copy link
Contributor

wamserma commented May 16, 2020

Please rename the PR or drop 9c7dcca from this PR.

email = "sgn.hamilton@protonmail.com";
github = "SCOTT-HAMILTON";
githubId = 24496705;
};

This comment has been minimized.

Copy link
@wamserma

wamserma May 16, 2020

Contributor

Please sort entries for better readability.

Copy link
Contributor

lourkeur left a comment

your package should be inserted in the wider nixpkgs with a callPackage expression in pkgs/top-level/all-packages.nix

Also please confirm that the point of this PR is to init otpgen.

EDIT: #87887

name = "OTPGen";

meta = {
description = "MULTI-PURPOSE OTP TOKEN GENERATOR WRITTEN IN C++ AND QT WITH ENCRYPTION AND SYSTEM TRAY ICON. SUPPORTS TOTP, HOTP, AUTHY AND STEAM AND CUSTOM DIGIT LENGTHS AND PERIODS.";

This comment has been minimized.

Copy link
@lourkeur

lourkeur May 16, 2020

Contributor

All caps is inappropriate here. The period as well. please conform to the manual.

pkgs/tools/security/otpgen/default.nix Outdated Show resolved Hide resolved
license = lib.licenses.mit;
homepage = "https://github.com/magiruuvelvet/OTPGen";
maintainers = [ "Scott Hamilton <sgn'dot'hamilton'at'protonmail'dot'com>" ];
priority = "10";

This comment has been minimized.

Copy link
@lourkeur

lourkeur May 16, 2020

Contributor

why does this package need to be low-priority?

homepage = "https://github.com/magiruuvelvet/OTPGen";
maintainers = [ "Scott Hamilton <sgn'dot'hamilton'at'protonmail'dot'com>" ];
priority = "10";
timeout = 3600;

This comment has been minimized.

Copy link
@lourkeur

lourkeur May 16, 2020

Contributor

Why does this package need a timeout?

@@ -0,0 +1,42 @@
{
pkgs ? import <nixpkgs> {}

This comment has been minimized.

Copy link
@lourkeur

lourkeur May 16, 2020

Contributor

default arguments shouldn't be used within nixpkgs. please use something like

{
  lib,
  stdenv,
  makeWrapper,
  fetchFromGithub,
  fakeSha256
  cmake,
  pkg-config,
  cryptopp,
  qtbase,
}:
SCOTT-HAMILTON and others added 2 commits May 16, 2020
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
@SCOTT-HAMILTON
Copy link
Contributor Author

SCOTT-HAMILTON commented May 16, 2020

Moved to #87938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.