Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] php74: 7.4.4 -> 7.4.6 #87937

Merged
merged 2 commits into from May 16, 2020
Merged

[20.03] php74: 7.4.4 -> 7.4.6 #87937

merged 2 commits into from May 16, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented May 16, 2020

Motivation for this change

Backport of #87907

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu added 2 commits Apr 15, 2020
Changelog: https://www.php.net/ChangeLog-7.php#7.4.5
(cherry picked from commit 52d2e99)
Changelog: https://www.php.net/ChangeLog-7.php#7.4.6
(cherry picked from commit a779efc)
@etu
Copy link
Contributor Author

@etu etu commented May 16, 2020

cc @NixOS/php

@ofborg build php
@ofborg build nixosTests.php

@talyz
talyz approved these changes May 16, 2020
Copy link
Contributor

@talyz talyz left a comment

  • Tested with nixpkgs-review
@talyz talyz merged commit bfa2cd0 into NixOS:release-20.03 May 16, 2020
23 checks passed
23 checks passed
nixosTests.php on aarch64-linux No attempt
Details
nixosTests.php on x86_64-darwin No attempt
Details
nixosTests.php on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="99f7c26"; rev="99f7c26f3fff6a0facf1073d200be02b6a442421"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
php on aarch64-linux Success
Details
php on x86_64-darwin Success
Details
php on x86_64-linux Success
Details
php74, php74.passthru.tests on aarch64-linux Success
Details
php74, php74.passthru.tests on x86_64-darwin Success
Details
php74, php74.passthru.tests on x86_64-linux Success
Details
@etu etu deleted the etu:20.03-php74-update branch May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.