Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accountsservice: add patch for upstream issue #55 #87943

Merged
merged 1 commit into from Jun 2, 2020

Conversation

@pbogdan
Copy link
Member

pbogdan commented May 16, 2020

Motivation for this change

Add upstream patch for https://gitlab.freedesktop.org/accountsservice/accountsservice/-/issues/55, fixes #47475.

Asked for a possibility of a new upstream release at https://gitlab.freedesktop.org/accountsservice/accountsservice/-/issues/55#note_500692 so marking this PR as draft for now pending upstream's response.

Things done

Been running my system with the patch applied locally and can confirm it fixes the issue on my end.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from pSub May 16, 2020
@pbogdan pbogdan force-pushed the pbogdan:accountsservice-upstream-55 branch from d6d75fb to 3e3ad2d May 24, 2020
@pbogdan pbogdan changed the title accounsservice: add patch for upstream issue #55 accountsservice: add patch for upstream issue #55 May 24, 2020
@pbogdan pbogdan force-pushed the pbogdan:accountsservice-upstream-55 branch from 3e3ad2d to b67e25b May 24, 2020
@pbogdan pbogdan marked this pull request as ready for review May 24, 2020
@pbogdan
Copy link
Member Author

pbogdan commented May 24, 2020

There's been no response from upstream in a week re: new release. As I would like very much to see the issue fixed I will stick to applying the patch in nixpkgs for now and mark this PR as ready for review. @jtojnar @worldofpeace could you perhaps take a look or recommend someone who might be able to review?

@pbogdan
Copy link
Member Author

pbogdan commented Jun 2, 2020

Hate to pester but would appreciate someone taking a look.

@jtojnar jtojnar merged commit 83489ca into NixOS:master Jun 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
accountsservice, accountsservice.passthru.tests on aarch64-linux Success
Details
accountsservice, accountsservice.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b67e25b"; rev="b67e25bf89bf5db5e615a23e56bf1c5105332703"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@pbogdan pbogdan deleted the pbogdan:accountsservice-upstream-55 branch Jun 2, 2020
@pbogdan
Copy link
Member Author

pbogdan commented Jun 2, 2020

Thank you @jtojnar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.