Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: enable tests + install docs + split outputs #87949

Merged
merged 4 commits into from Jun 5, 2020
Merged

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 16, 2020

Motivation for this change

I want to have the docs installed and they aren't installed if mesonFlags don't include -Ddocumentation=true.

Also, I noticed there are tests which I enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar mentioned this pull request May 16, 2020
5 of 10 tasks complete
@ofborg ofborg bot requested review from tobim, astsmtl, ehmry and fpletz May 16, 2020
@doronbehar doronbehar changed the title mpd: enable tests + install docs to split outputs mpd: enable tests + install docs + split outputs May 16, 2020
@ehmry
ehmry approved these changes May 17, 2020
@doronbehar doronbehar mentioned this pull request May 30, 2020
4 of 10 tasks complete
@marsam
marsam approved these changes Jun 5, 2020
@marsam marsam merged commit 810f240 into NixOS:master Jun 5, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08bdd8b"; rev="08bdd8bc434ea0bd2c6eb4fb1a3a74870d7307c5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mpd, mpd.passthru.tests on aarch64-linux Success
Details
mpd, mpd.passthru.tests on x86_64-darwin Success
Details
mpd, mpd.passthru.tests on x86_64-linux Success
Details
@doronbehar doronbehar mentioned this pull request Jun 6, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.