Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glpaper: init at unstable-2020-03-30 #87953

Merged
merged 2 commits into from May 17, 2020
Merged

Conversation

@ccellado
Copy link
Contributor

ccellado commented May 16, 2020

Motivation for this change

Add new useful package to the Wayland stack.

Things done

Added glpaper package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ccellado ccellado force-pushed the ccellado:glpaper-unstable branch from 50e83b9 to 0e3137b May 16, 2020
@ccellado ccellado closed this May 16, 2020
@ccellado ccellado force-pushed the ccellado:glpaper-unstable branch from 0e3137b to fe5479f May 16, 2020
@ccellado ccellado reopened this May 16, 2020
@ccellado ccellado force-pushed the ccellado:glpaper-unstable branch from c3dc55e to aa0f483 May 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

Could you also rebase the branch to fixup Update pkgs/development/tools/glpaper/default.nix onto the glpaper commit?

@ccellado ccellado force-pushed the ccellado:glpaper-unstable branch from aa0f483 to 948224e May 16, 2020
@ccellado
Copy link
Contributor Author

ccellado commented May 16, 2020

Could you also rebase the branch to fixup Update pkgs/development/tools/glpaper/default.nix onto the glpaper commit?

Squashed, did that

@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

Could you also move the maintainer commit before the package commit (e.g. using git rebase -i HEAD^^). Otherwise there will be broken evaluation which might break git bisect.

@ccellado ccellado force-pushed the ccellado:glpaper-unstable branch from 948224e to 221e5eb May 16, 2020
@ccellado
Copy link
Contributor Author

ccellado commented May 16, 2020

Could you also move the maintainer commit before the package commit (e.g. using git rebase -i HEAD^^). Otherwise there will be broken evaluation which might break git bisect.

Looks like it worked.

@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Could you please push the changes?

@ccellado
Copy link
Contributor Author

ccellado commented May 17, 2020

Could you please push the changes?

I don't quite understand. I've pushed after reordering, my commit list here displays Maintainer commit before the main commit.

@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Hmm, you are right, GitHub just displays them in the wrong order here:

image

@jtojnar jtojnar merged commit c19fa9b into NixOS:master May 17, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
glpaper, glpaper.passthru.tests on aarch64-linux Success
Details
glpaper, glpaper.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="221e5eb"; rev="221e5eba47110ef9a174e2c5caf66351609c16ba"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Thanks.

@ccellado
Copy link
Contributor Author

ccellado commented May 17, 2020

Thanks.

Thank your patience, I'm new to contributing <3

@ccellado ccellado deleted the ccellado:glpaper-unstable branch May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.