Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowners: Move code ownership to php maintainer team #87955

Merged
merged 1 commit into from May 16, 2020

Conversation

@etu
Copy link
Contributor

etu commented May 16, 2020

Motivation for this change

Since we now have a maintainer team and @NixOS/php, I thought we can move the code ownership to the team 馃檪

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@adisbladis
Copy link
Member

adisbladis commented May 16, 2020

Could you change the commit message to clarify that this is for php?

@etu etu force-pushed the etu:php-codeowner-team branch from 43758de to 3d3519e May 16, 2020
@etu etu changed the title codeowners: Move code ownership to maintainer team codeowners: Move code ownership to php maintainer team May 16, 2020
@talyz
talyz approved these changes May 16, 2020
@adisbladis adisbladis merged commit d5522d6 into NixOS:master May 16, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d3519e"; rev="3d3519e2c3af00fd75c58364ae93f8cac5879e43"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@etu etu deleted the etu:php-codeowner-team branch May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.