Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graalvm8-19.2.1 buildfix #87958

Closed
wants to merge 1 commit into from
Closed

Conversation

@hlolli
Copy link
Member

@hlolli hlolli commented May 16, 2020

Motivation for this change

Hydra build failures on linux https://hydra.nixos.org/build/118583841 and darwin https://hydra.nixos.org/build/118579881

Things done
  • fix xcode build related bug on darwin
  • print graalvm-native build log by default
  • fix graal-nodejs runner shortcut
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ludovicc
Copy link

@ludovicc ludovicc commented Aug 9, 2020

Failed to build on Darwin:

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 87958"

[...]

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/lclaude/.cache/nixpkgs-review/pr-87958/build.nix
builder for '/nix/store/fmgshivpz9h1bp3hyymbs59sljw3j9b2-jvmci-19.3-b05.drv' failed with exit code 1; last 10 log lines:
    File "/nix/store/g03a391s1w7gxnffgyns3gw3w5y5yykw-mx-5.247.1/bin/internal_mx.py", line 6863, in prepare
      self.compiler.prepare_daemon(daemons, self.compileArgs)
    File "/nix/store/g03a391s1w7gxnffgyns3gw3w5y5yykw-mx-5.247.1/bin/internal_mx.py", line 7206, in prepare_daemon
      self.daemon = JavacDaemon(self.jdk, jvmArgs)
    File "/nix/store/g03a391s1w7gxnffgyns3gw3w5y5yykw-mx-5.247.1/bin/internal_mx.py", line 7319, in __init__
      CompilerDaemon.__init__(self, jdk, jvmArgs, 'com.oracle.mxtool.compilerserver.JavacDaemon', jdk.toolsjar, ['--force-javac'])
    File "/nix/store/g03a391s1w7gxnffgyns3gw3w5y5yykw-mx-5.247.1/bin/internal_mx.py", line 7255, in __init__
      raise RuntimeError('Error starting ' + self.name() + ': returncode=' + str(returncode) + '\n' + ''.join(pout))
  RuntimeError: Error starting javac-daemon: returncode=1

cannot build derivation '/nix/store/bkfyqmbp03fav9a43czppb9dz0k3qwrd-graal-19.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cywkwgm3w89z90l7kgzlkanayg2siyyn-clj-kondo-2019.12.14.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7mlvcrfvbrgi51df2xq3ahid1w69hkps-env.drv': 2 dependencies couldn't be built
[1 built (1 failed), 196 copied (2312.8 MiB), 625.9 MiB DL]
error: build of '/nix/store/7mlvcrfvbrgi51df2xq3ahid1w69hkps-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/87958
2 packages failed to build:
clj-kondo graalvm8

[0.0 MiB DL]
error: build log of '/nix/store/cywkwgm3w89z90l7kgzlkanayg2siyyn-clj-kondo-2019.12.14.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/bkfyqmbp03fav9a43czppb9dz0k3qwrd-graal-19.2.1.drv' is not available
$ nix-shell /Users/lclaude/.cache/nixpkgs-review/pr-87958/shell.nix
these paths will be fetched (1.46 MiB download, 7.85 MiB unpacked):
  /nix/store/02n29ivj4fcpyhj8wh1simy08lxg2pmr-bash-interactive-4.4-p23-dev
  /nix/store/bl9zgywn70jbm2wf9qmhhpswj3dvl2hn-bash-interactive-4.4-p23-doc
  /nix/store/i3bf9dywv5j6wbpw32j3v2i2k07dxsl4-bash-interactive-4.4-p23-info
  /nix/store/kpmw1b9sbh5hy67p0slvgfjrdiqbw6z7-bash-interactive-4.4-p23
  /nix/store/qf3g0lgkn57wd0n3fixfmq3g57xnjn3k-bash-interactive-4.4-p23-man
  /nix/store/zgkasmai95mm4ibdjj0iv5j8aigyikas-readline-7.0p5
copying path '/nix/store/bl9zgywn70jbm2wf9qmhhpswj3dvl2hn-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/i3bf9dywv5j6wbpw32j3v2i2k07dxsl4-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/qf3g0lgkn57wd0n3fixfmq3g57xnjn3k-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/zgkasmai95mm4ibdjj0iv5j8aigyikas-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/kpmw1b9sbh5hy67p0slvgfjrdiqbw6z7-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/02n29ivj4fcpyhj8wh1simy08lxg2pmr-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 9, 2020

@GrahamcOfBorg build graalvm8

@hlolli
Copy link
Member Author

@hlolli hlolli commented Aug 10, 2020

@ludovicc I'm curious to see what @grahamc does. This would be the jvmci which is failling for you, that's a relief imo. Why it's failing is hard to say, but I'm not sure this will work sandboxed on darwin, since it's using /Libraries/Java modules built into the macos system. I'm not a osx expert, but I have one and will test again soon.

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 11, 2020

I think ofborg does not build with sandbox on macOS. Nixpkgs-review does. Is this an actual regression or has this been problem before? Is there a way to override where java modules are loaded from?

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 11, 2020

@conferno I am on the list but the builder does not process any builds at the moment.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Due to the number of PRs nixpkgs gets every month we didn't review and merge this on in time before 20.03 hit EOL. If you think this PR is still relevant please rebase it on master or 20.09 and leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants