Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 02/2020 backports #87961

Merged
merged 5 commits into from May 17, 2020
Merged

vscode: 02/2020 backports #87961

merged 5 commits into from May 17, 2020

Conversation

@eadwu
Copy link
Member

eadwu commented May 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
kuznero and others added 5 commits Apr 20, 2020
(cherry picked from commit ba774d4)
(cherry picked from commit 301905d)
(cherry picked from commit 36fb04b)
The option "--skip-getting-started" no longer exists in vscode and causes files in "$@" to not be opened.
Message from stdout: "Warning: 'skip-getting-started' is not in the list of known options, but still passed to Electron/Chromium."
"--skip-getting-started" being removed: microsoft/vscode@6a8b201

(cherry picked from commit f1e6d96)
(cherry picked from commit 91f58ec)
@eadwu
Copy link
Member Author

eadwu commented May 16, 2020

@eadwu eadwu requested a review from kuznero May 16, 2020
@ofborg ofborg bot requested a review from Synthetica9 May 16, 2020
@marsam marsam merged commit 025deb8 into NixOS:release-20.03 May 17, 2020
16 checks passed
16 checks passed
vscode, vscode.passthru.tests, vscodium, vscodium.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9624df4"; rev="9624df4bc67c0889b546f3f2b0783e057c009b09"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vscode, vscode.passthru.tests, vscodium, vscodium.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.