Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: Fix build #87965

Merged
merged 1 commit into from May 19, 2020
Merged

kodi: Fix build #87965

merged 1 commit into from May 19, 2020

Conversation

@samdoshi
Copy link
Contributor

samdoshi commented May 16, 2020

Motivation for this change

Fixes the kodi build. See #86770.

From the looks of it, the build was unable to find the following headers: <X11/extensions/Xrandr.h> & <X11/extensions/dpms.h>

Could NOT find XRandR (missing: XRANDR_INCLUDE_DIR)
/build/source/xbmc/powermanagement/DPMSSupport.cpp:99:10: fatal error: X11/extensions/dpms.h: No such file or directory
   99 | #include <X11/extensions/dpms.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~

I've fixed this by switching libXext to libXext.dev and libXrandr to libXrandr.dev in the buildInputs.

I have checked that kodi runs, but only the kodi derivation, not kodi-gbm or kodi-wayland.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from domenkozar, edwtjo, peterhoeg, titanous and sephalon May 16, 2020
@samdoshi samdoshi mentioned this pull request May 18, 2020
@peterhoeg peterhoeg merged commit 200f8ba into NixOS:master May 19, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5c0bc8"; rev="c5c0bc82d77f603fd0c065b384373aa2b8d24130"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kodi, kodi.passthru.tests on aarch64-linux Success
Details
kodi, kodi.passthru.tests on x86_64-linux Success
Details
@samdoshi samdoshi deleted the samdoshi:kodi branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.