Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraria-server: 1.3.5.3 -> 1.4.0.3 #87966

Merged
merged 1 commit into from May 22, 2020
Merged

Conversation

@dasJ
Copy link
Member

dasJ commented May 16, 2020

Also use autoPatchelfHook and nixfmt it

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@privateseabass
Copy link
Contributor

privateseabass commented May 16, 2020

This built and ran for me.

@erebid
Copy link
Contributor

erebid commented May 17, 2020

1.4.0.1 has been superseded by 1.4.0.2, which for some reason isn't available from https://terraria.org/server/terraria-server-1402.zip, but instead https://terraria.org/system/dedicated_servers/archives/000/000/036/original/terraria-server-1402.zip.

@ajs124
ajs124 approved these changes May 17, 2020
@dasJ dasJ force-pushed the helsinki-systems:upd/terraria14 branch from e1f05a2 to a5709fe May 17, 2020
@dasJ dasJ changed the title terraria-server: 1.3.5.3 -> 1.4.0.1 terraria-server: 1.3.5.3 -> 1.4.0.2 May 17, 2020
@dasJ
Copy link
Member Author

dasJ commented May 17, 2020

@erebid Thanks, updated

@erebid
Copy link
Contributor

erebid commented May 21, 2020

Terraria has now been updated to 1.4.0.3, and the server download URL is https://terraria.org/system/dedicated_servers/archives/000/000/037/original/terraria-server-1403.zip

Also use autoPatchelfHook and nixfmt it
@dasJ dasJ changed the title terraria-server: 1.3.5.3 -> 1.4.0.2 terraria-server: 1.3.5.3 -> 1.4.0.3 May 21, 2020
@dasJ dasJ force-pushed the helsinki-systems:upd/terraria14 branch from a5709fe to 466fb98 May 21, 2020
@dasJ
Copy link
Member Author

dasJ commented May 21, 2020

@erebid Thanks, updated

@ajs124 ajs124 self-requested a review May 21, 2020
@ajs124
ajs124 approved these changes May 21, 2020
@dasJ dasJ requested review from Lassulus and ajs124 May 21, 2020
@ajs124
ajs124 approved these changes May 21, 2020
@Lassulus Lassulus merged commit 571212e into NixOS:master May 22, 2020
17 checks passed
17 checks passed
editorconfig editorconfig
Details
terraria-server, terraria-server.passthru.tests on aarch64-linux No attempt
Details
terraria-server, terraria-server.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="466fb98"; rev="466fb98bcd8bb7b832e1e2b70ab7fd085764fcce"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dasJ dasJ deleted the helsinki-systems:upd/terraria14 branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.