Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fakeXinerama: clean up minor issues #87983

Open
wants to merge 2 commits into
base: master
from

Conversation

@lourkeur
Copy link
Contributor

lourkeur commented May 16, 2020

Motivation for this change

Originally I was putting fire on a xpra bug, but now it seems that this isn't strictly necessary. Still, applying some hygiene on this package now could help maintainers in the future.

Things done
  • Fix dangling symlinks
  • don't set phases on derivation because that's discouraged

TODO: e-mail maintainer Thomas Strobel

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lourkeur lourkeur marked this pull request as ready for review May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.