Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] Backport SOF #87988

Merged
merged 2 commits into from May 17, 2020
Merged

[20.03] Backport SOF #87988

merged 2 commits into from May 17, 2020

Conversation

@phunehehe
Copy link
Contributor

phunehehe commented May 16, 2020

Motivation for this change

This allows using SOF in 20.03 by switching to a new kernel. I figure this should be okay because it doesn't touch the default kernel. The commits come from #86168.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92
Copy link
Contributor

Mic92 commented May 17, 2020

Since it adds hardware driver & firmware that would not be used otherwise this looks safe to me. cc @NeQuissimus

lblasc added 2 commits Apr 28, 2020
(cherry picked from commit fe7f770)
(cherry picked from commit 6fc9fd5)
@phunehehe phunehehe force-pushed the phunehehe:sof-20.03 branch from 671dee6 to 2e1c5de May 17, 2020
@Mic92 Mic92 merged commit 4d20bbc into NixOS:release-20.03 May 17, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e1c5de"; rev="2e1c5ded91e582e2e9e6aedbe8e4bdc7bf5e00ff"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sof-firmware, sof-firmware.passthru.tests on aarch64-linux Success
Details
sof-firmware, sof-firmware.passthru.tests on x86_64-linux Success
Details
@phunehehe phunehehe deleted the phunehehe:sof-20.03 branch May 17, 2020
@nixos-discourse
Copy link

nixos-discourse commented May 25, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/install-sound-open-firmware/6535/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.