Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ptvsd: init at 4.3.2 #88005

Closed
wants to merge 2 commits into from

Conversation

@leungbk
Copy link

leungbk commented May 17, 2020

Motivation for this change

Add ptvsd, a Python debugging tool compliant with the Debug Adapter Protocol.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@leungbk
Copy link
Author

leungbk commented May 18, 2020

@leungbk leungbk requested a review from ptrhlm May 18, 2020
@jonringer
Copy link
Contributor

jonringer commented May 19, 2020

thanks for opening your first PR! :)

@leungbk
Copy link
Author

leungbk commented May 19, 2020

@leungbk leungbk force-pushed the leungbk:pythonPackages-ptvsd branch from e8d1a20 to 579e3e9 May 19, 2020
@leungbk leungbk requested a review from jonringer May 19, 2020
@ptrhlm
ptrhlm approved these changes May 29, 2020
Copy link
Contributor

ptrhlm left a comment

I've tested your changes with Python 3.7 and VS Code. Seems to work. Great job

# no tests in the wheel or the zip
doCheck = false;
Comment on lines +13 to +14

This comment has been minimized.

Copy link
@jonringer

jonringer May 29, 2020

Contributor

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.

@leungbk
Copy link
Author

leungbk commented Jun 6, 2020

Apparently ptvsd was deprecated May 4, well before I made this PR, but it was advertised on the deprecate branch and not on the master branch: https://github.com/microsoft/ptvsd/tree/deprecate

So I'll close this.

@leungbk leungbk closed this Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.